Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sogo: init at 4.3.2 #79175

Merged
merged 5 commits into from May 22, 2020
Merged

sogo: init at 4.3.2 #79175

merged 5 commits into from May 22, 2020

Conversation

@ajs124
Copy link
Member

ajs124 commented Feb 3, 2020

Motivation for this change

Replaces #65530

Reverts #62464, because that upgrade makes sogod segfault. (#60296 is related)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@dasJ
dasJ approved these changes Feb 3, 2020
Copy link
Member

dasJ left a comment

"Lernen"

@ajs124 ajs124 force-pushed the helsinki-systems:init/sogo branch from 109493f to 97d1eaa Feb 3, 2020
@ofborg ofborg bot requested a review from dasJ Feb 3, 2020
@dasJ
Copy link
Member

dasJ commented Feb 3, 2020

@ajs124 What about a simple test that just checks whether sogod starts successfully and the login page is reachable with HTTP 200? Shouldn't require LDAP, IMAP, or SMTP

@dasJ dasJ mentioned this pull request Feb 5, 2020
4 of 10 tasks complete
@ajs124 ajs124 mentioned this pull request Feb 13, 2020
2 of 10 tasks complete
Copy link
Contributor

herrwiese left a comment

I'd generally really appreciate this getting merged.

@ajs124 ajs124 force-pushed the helsinki-systems:init/sogo branch from 97d1eaa to a4eed09 Apr 17, 2020
@ajs124
Copy link
Member Author

ajs124 commented Apr 17, 2020

I'd generally really appreciate this getting merged.

So there's somebody else crazy enough to run this, besides us @dasJ 💯

@ofborg ofborg bot requested a review from ashalkhakov Apr 17, 2020
@ajs124 ajs124 force-pushed the helsinki-systems:init/sogo branch from a4eed09 to 65e0338 May 2, 2020
@ajs124 ajs124 force-pushed the helsinki-systems:init/sogo branch from 65e0338 to e001f57 May 12, 2020
@ajs124 ajs124 changed the title sogo: init at 4.3.0 sogo: init at 4.3.2+ May 12, 2020
@ajs124 ajs124 changed the title sogo: init at 4.3.2+ sogo: init at 4.3.2 May 12, 2020
@ofborg ofborg bot added the 6.topic: nixos label May 12, 2020
@Lassulus Lassulus merged commit d84d8e8 into NixOS:master May 22, 2020
16 checks passed
16 checks passed
sogo, sogo.passthru.tests, sope, sope.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e001f57"; rev="e001f5760e4b342e20ba4d91f54a1745f2d4cc53"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e001f57"; rev="e001f5760e4b342e20ba4d91f54a1745f2d4cc53"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e001f57"; rev="e001f5760e4b342e20ba4d91f54a1745f2d4cc53"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e001f57"; rev="e001f5760e4b342e20ba4d91f54a1745f2d4cc53"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e001f57"; rev="e001f5760e4b342e20ba4d91f54a1745f2d4cc53"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e001f57"; rev="e001f5760e4b342e20ba4d91f54a1745f2d4cc53"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e001f57"; rev="e001f5760e4b342e20ba4d91f54a1745f2d4cc53"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sogo, sogo.passthru.tests, sope, sope.passthru.tests on x86_64-linux Success
Details
@dasJ dasJ deleted the helsinki-systems:init/sogo branch May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.