Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sogo: init at 4.3.2 #79175

Merged
merged 5 commits into from May 22, 2020
Merged

sogo: init at 4.3.2 #79175

merged 5 commits into from May 22, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Feb 3, 2020 •
edited

Motivation for this change

Replaces #65530

Reverts #62464, because that upgrade makes sogod segfault. (#60296 is related)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from dasJ and matthewbauer February 3, 2020 20:17
dasJ
dasJ approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Lernen"

@ofborg ofborg bot requested a review from dasJ February 3, 2020 22:02
@dasJ
Copy link
Member

dasJ commented Feb 3, 2020

@ajs124 What about a simple test that just checks whether sogod starts successfully and the login page is reachable with HTTP 200? Shouldn't require LDAP, IMAP, or SMTP

@dasJ dasJ mentioned this pull request Feb 5, 2020
Closed
10 tasks
@ajs124 ajs124 mentioned this pull request Feb 13, 2020
Closed
10 tasks
herrwiese
herrwiese suggested changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@herrwiese herrwiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd generally really appreciate this getting merged.

@ajs124
Copy link
Member Author

ajs124 commented Apr 17, 2020 •
edited

I'd generally really appreciate this getting merged.

So there's somebody else crazy enough to run this, besides us @dasJ 💯

@ofborg ofborg bot requested a review from ashalkhakov April 17, 2020 19:08
@ajs124 ajs124 mentioned this pull request Apr 19, 2020
Closed
@ajs124 ajs124 changed the title sogo: init at 4.3.0 sogo: init at 4.3.2+ May 12, 2020
@ajs124 ajs124 changed the title sogo: init at 4.3.2+ sogo: init at 4.3.2 May 12, 2020
@Lassulus Lassulus merged commit d84d8e8 into NixOS:master May 22, 2020
@dasJ dasJ deleted the init/sogo branch May 22, 2020 11:49
@ajs124 ajs124 mentioned this pull request Jun 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@herrwiese herrwiese herrwiese requested changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@dasJ dasJ Awaiting requested review from dasJ

@ashalkhakov ashalkhakov Awaiting requested review from ashalkhakov

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ajs124 @dasJ @Mic92 @herrwiese @Lassulus