Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/redis: add redis group #90027

Merged
merged 1 commit into from Jun 10, 2020
Merged

nixos/redis: add redis group #90027

merged 1 commit into from Jun 10, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 10, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Jun 10, 2020

Related to #55370

@Mic92
Copy link
Member Author

Mic92 commented Jun 10, 2020

In particular this allows to have a redis group that has access to redis unix socket.

mweinelt
mweinelt approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mweinelt
Copy link
Member

In particular this allows to have a redis group that has access to redis unix socket.

Which is why DynamicUser is out of the question, right.

@Mic92 Mic92 merged commit 7a4ee35 into NixOS:master Jun 10, 2020
@Mic92 Mic92 deleted the redis branch June 10, 2020 18:02
@dadada dadada mentioned this pull request Jan 3, 2021
Closed
10 tasks
dadada added a commit to dadada/nixpkgs that referenced this pull request Jan 3, 2021
@dadada
nixos/redis: change unix socket permissions
5ead42f 
This makes the redis unix socket accessible to the `redis` group. This group
was added in NixOS#90027.
dadada added a commit to dadada/nixpkgs that referenced this pull request Jan 9, 2021
@dadada
nixos/redis: add test for unix socket access
5d0b0fc 
This adds a test to check if the unix socket is available to the `redis` group
added in NixOS#90027.
@dadada dadada mentioned this pull request Jan 9, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @mweinelt