Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
maintainers: rename 1000101 to b1000101 #90029
Having a name starting with numbers is a problem because
with maintainers; [ 1000101 ];
does not work and there have been cases where people dripped over it
Motivation for this change
Having a name starting with numbers is a problem because the common pattern: with maintainers; [ 1000101 ]; does not work and there have been cases where people dripped over it including fixes in this PR itself.
That's how I've been doing it so far. I forgot to fix those 3 instances where I used it incorrectly (2 due to lack of knowledge, 1 that's in tests is totally my fault). Had it on my list, but forgot to open PR - sorry about that.
The problem is that it is easy to get wrong. I had another PR where somebody introduced a bug:
- maintainers = with maintainers; [ maintainers."1000101" ]; + maintainers = with maintainers; [ "1000101" mdlayher ];
Which was the motivation to create this PR. Do really want to leave this trip wire for something else to fall over?
@Mic92 I've opened a PR which should fix my previous mistakes. I'm really sorry for all the trouble I've caused. If you want to fix this by changing my name, then go ahead, but at the same time, I think it's fine to have an edge case (like myself) to uncover weird behaviour. I'm not sure how many people have nick starting with a number, but I bet it's only a matter of time when someone else breaks the system.