-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintainers: rename 1000101 to b1000101 #90029
Conversation
Having a name starting with numbers is a problem because the common pattern: with maintainers; [ 1000101 ]; does not work and there have been cases where people dripped over it including fixes in this PR itself.
cc @1000101 |
Alternately, we could explicitly use It also feels like a good reason to support attrsets in |
That's how I've been doing it so far. I forgot to fix those 3 instances where I used it incorrectly (2 due to lack of knowledge, 1 that's in tests is totally my fault). Had it on my list, but forgot to open PR - sorry about that. |
The problem is that it is easy to get wrong. I had another PR where somebody introduced a bug: - maintainers = with maintainers; [ maintainers."1000101" ];
+ maintainers = with maintainers; [ "1000101" mdlayher ]; Which was the motivation to create this PR. Do really want to leave this trip wire for something else to fall over? |
Should not meta check pick it up? I find not mangling contributor names preferable, even if we used |
It does not; this pr itself also fix three broken instances. |
Maybe we should fix the meta check fix instead of this work around? |
Can we use the same underscore prefix style that is already used by packages? |
@Mic92 I've opened a PR which should fix my previous mistakes. I'm really sorry for all the trouble I've caused. If you want to fix this by changing my name, then go ahead, but at the same time, I think it's fine to have an edge case (like myself) to uncover weird behaviour. I'm not sure how many people have nick starting with a number, but I bet it's only a matter of time when someone else breaks the system. So:
|
Too much bike-shedding here. I give up. |
PR to use a underscore prefix like we do for packages: #95553 |
Having a name starting with numbers is a problem because
the common pattern:
with maintainers; [ 1000101 ];
does not work and there have been cases where people dripped over it
including fixes in this PR itself.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)