Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libzip: 1.6.1 -> 1.7.1 #90610

Open
wants to merge 1 commit into
base: staging
from
Open

Conversation

@r-ryantm
Copy link
Contributor

r-ryantm commented Jun 16, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libzip/versions.

meta.description for libzip is: "A C library for reading, creating and modifying zip archives"

meta.homepage for libzip is: "https://www.nih.at/libzip"

meta.changelog for libzip is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
496 total rebuild path(s)

196 package rebuild(s)

196 x86_64-linux rebuild(s)
129 i686-linux rebuild(s)
43 x86_64-darwin rebuild(s)
128 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
adminer
ahoviewer
arcanist
ark
cntk
collectd
collectd-data
deadbeef
deadbeef-with-plugins
digikam
dolphin
dragon
drush
dsview
ebook_tools
elisa
fileshelter
freedink
gImageReader
gimp
gimp-with-plugins
gimpPlugins.exposureBlend
gimpPlugins.focusblur
gimpPlugins.fourier
gimpPlugins.gap
gimpPlugins.gimplensfun
gimpPlugins.gmic
gimpPlugins.lightning
gimpPlugins.lqrPlugin
gimpPlugins.resynthesizer
gimpPlugins.resynthesizer2
gimpPlugins.texturize
gimpPlugins.ufraw
gimpPlugins.waveletSharpen
gwenview
gwyddion
haskellPackages.LibZip
haskellPackages.bindings-libzip
hhvm
icingaweb2
ideviceinstaller
idevicerestore
k3b
katago
katagoWithCuda
kcachegrind
kde-cli-tools
kdeApplications.ark
kdeApplications.baloo-widgets
kdeApplications.dolphin
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/6rib6a09dnnmc2y4sdcmg6xs7x8gwj5y-libzip-1.7.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A libzip https://github.com/r-ryantm/nixpkgs/archive/9d3f24f3444c2c3065ba5af932d14c3d3140d58a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/6rib6a09dnnmc2y4sdcmg6xs7x8gwj5y-libzip-1.7.1
ls -la /nix/store/6rib6a09dnnmc2y4sdcmg6xs7x8gwj5y-libzip-1.7.1/bin


Pre-merge build results

NixPkgs review skipped


Maintainer pings
@r-ryantm r-ryantm closed this Jul 1, 2020
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/libzip branch Jul 1, 2020
@ryantm ryantm restored the r-ryantm:auto-update/libzip branch Jul 1, 2020
@ryantm ryantm reopened this Jul 1, 2020
@FRidh
Copy link
Member

FRidh commented Jul 2, 2020

@jtojnar
Copy link
Contributor

jtojnar commented Jul 6, 2020

Changes:

Looks like it will be necessary to fix the newly available CMake module. The project does not even make the includedir configurable:

https://github.com/nih-at/libzip/blob/4fba16a97928f7ec2a77745ae44ca206ff8336a1/lib/CMakeLists.txt#L181

So we will need to add GNUInstallDirs support (include the module and replace $<INSTALL_INTERFACE:include> by $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}> at minimum)

The pkg-config file should also be fixed as described in https://github.com/jtojnar/cmake-snips#concatenating-paths-when-building-pkg-config-files so that we do not need to replace it:

https://github.com/nih-at/libzip/blob/1d543702ce1a55119dd179bef39cc257ebbcd9f2/CMakeLists.txt#L311-L313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CMake breakage
  
To do
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.