Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomachine-client: 6.10.12 -> 6.11.2 #91130

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Conversation

austinbutler
Copy link
Member

@austinbutler austinbutler commented Jun 19, 2020

Motivation for this change

Current version fails, so upgrading to the current version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@austinbutler
Copy link
Member Author

I'm not clear on whether I actually built with sandboxing or not. The sandboxing option linked for NixOS in the PR template says the default value for useSandbox is true. However this wiki page says "Sandboxes are not enabled by default." In my case on NixOS I haven't set the option at all.

@talyz
Copy link
Contributor

talyz commented Jun 23, 2020

Thank you for updating!

Sandboxing is enabled by default on Linux (see the sandbox option in the nix.conf man page) - the wiki page info is out-of-date.

@talyz talyz merged commit 926afba into NixOS:master Jun 23, 2020
@austinbutler austinbutler deleted the nomachine-6.11.2 branch May 24, 2021 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants