Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make-desktopitem: refactoring, documentation and improvement #91790

Open
wants to merge 1 commit into
base: master
from

Conversation

@piegamesde
Copy link

piegamesde commented Jun 29, 2020

Motivation for this change
  • New parameter extraDesktopEntries to easily add some less usual entries to the desktop file
  • Rewrite of the core logic. Instead of a key-value-list, use an attribute set with nullable values to make it overridable
  • Added some comments
  • Some cosmetic/readability code refactors
    • I didn't like the doubly nested strings around the fileValidation
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
- New parameter `extraDesktopEntries` to easily add some less usual entries to the desktop file
- Rewrite of the core logic. Instead of a key-value-list, use an attribute set with nullable values to make it overridable
- Added some comments
- Some cosmetic/readability code refactors
	- I didn't like the doubly nested strings around the `fileValidation`
@mweinelt
Copy link
Member

mweinelt commented Jun 30, 2020

Result of nixpkgs-review pr 91790 1

5 packages marked as broken and skipped:
- eagle7
- invoice2data
- pdfdiff
- pgadmin
- xpdf
24 packages failed to build:
- citrix_workspace (citrix_workspace_unwrapped ,citrix_workspace_unwrapped_20_04_0)
- citrix_workspace_19_10_0 (citrix_workspace_unwrapped_19_10_0)
- citrix_workspace_19_12_0 (citrix_workspace_unwrapped_19_12_0)
- citrix_workspace_19_6_0 (citrix_workspace_unwrapped_19_6_0)
- citrix_workspace_19_8_0 (citrix_workspace_unwrapped_19_8_0)
- frogatto
- ipmiview
- ostinato
- palemoon
- python37Packages.spyder
- spyder (python38Packages.spyder)
- quartus-prime-lite
- react-native-debugger
- sage
- sageWithDoc
- softmaker-office
- sqldeveloper
- stm32cubemx
- tdm
- termius
- toggldesktop
- tome2
- ut2004demo
- worldofgoo
168 packages built:
- _90secondportraits
- airtame
- alloy (alloy5)
- alloy4
- android-studio (androidStudioPackages.stable)
- androidStudioPackages.beta
- androidStudioPackages.canary
- androidStudioPackages.dev
- anydesk
- apache-directory-studio
- assaultcube
- avocode
- basex
- beneath-a-steel-sky
- betaflight-configurator
- bitwarden
- brogue
- broken-sword-25
- ccemux
- charles (charles4)
- charles3
- clipgrab
- cura_stable
- dbeaver
- ddccontrol
- discord
- discord-canary
- discord-ptb
- dolphinEmuMaster
- dosbox
- drascula-the-vampire-strikes-back
- dreamweb
- dropbox
- dropbox-cli
- eagle
- eclipses.eclipse-committers
- eclipses.eclipse-cpp
- eclipses.eclipse-java
- eclipses.eclipse-modeling
- eclipses.eclipse-platform
- eclipses.eclipse-scala-sdk
- eclipses.eclipse-sdk
- eduke32
- evilpixie
- flight-of-the-amazon-queen
- freeoffice
- frostwire
- ganttproject-bin
- ghidra-bin
- gitkraken
- gitter
- goattracker
- goattracker-stereo
- golden-cheetah
- gomuks
- gpsprune
- groove
- hakuneko
- hyperrogue
- ivan
- jabref
- jameica
- jd-gui
- jdiskreport
- jetbrains.clion
- jetbrains.datagrip
- jetbrains.goland
- jetbrains.idea-community
- jetbrains.idea-ultimate
- jetbrains.mps
- jetbrains.phpstorm
- jetbrains.pycharm-community
- jetbrains.pycharm-professional
- jetbrains.rider
- jetbrains.ruby-mine
- jetbrains.webstorm
- jitsi
- jmol
- joplin-desktop
- keen4
- keepass
- kodestudio
- leo-editor
- lighttable
- lure-of-the-temptress
- mame
- mari0
- mate.caja-dropbox
- mgba
- michabo
- mindustry
- minecraft
- mist
- mlterm
- monero-gui
- mrrescue
- munt
- netbeans
- netlogo
- nixui
- nottetris2
- obinskit
- open-ecard
- openjk
- orthorobot
- pdfsam-basic
- pharo
- pharo-launcher
- portfolio
- postman
- prusa-slicer
- pymol
- qpaeq
- rambox-pro
- ricochet
- rimshot
- riot-desktop
- robo3t
- rocksndiamonds
- rstudio
- rstudioWrapper
- runelite
- rxvt-unicode
- rxvt-unicode-unwrapped
- saleae-logic
- scid-vs-pc
- sidequest
- sienna
- simplenote
- slic3r
- slimerjs
- smartgithg
- squirrel-sql
- ssb-patchwork
- sublime
- svxlink
- sweethome3d.application
- sweethome3d.furniture-editor
- sweethome3d.textures-editor
- swingsane
- system-syzygy
- teamspeak_client
- teleprompter
- tensor
- thunderbird
- tlaplusToolbox
- todoist-electron
- tome4
- transgui
- trilium-desktop
- tusk
- tvbrowser-bin
- vapor
- vice
- vis
- visualvm
- vscode
- vscode-with-extensions
- vscodium
- wasabiwallet
- webbrowser
- winpdb
- wire-desktop
- write_stylus
- xmind
- xournal
- zotero
- zsnes
@piegamesde
Copy link
Author

piegamesde commented Jul 7, 2020

As far as I can tell, this change does not break anything. The packages that don't build are either broken with compile errors, or broke because of #75729.

@mweinelt mweinelt requested review from bjornfor and worldofpeace Jul 8, 2020
@nixos-discourse
Copy link

nixos-discourse commented Aug 5, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/247

@worldofpeace
Copy link
Member

worldofpeace commented Aug 6, 2020

Oops, I'll see if I can look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.