Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btlejack: init at 2.0.0 #92045

Open
wants to merge 5 commits into
base: master
from
Open

btlejack: init at 2.0.0 #92045

wants to merge 5 commits into from

Conversation

@oxzi
Copy link
Member

oxzi commented Jul 2, 2020

Motivation for this change

This PR adds the btlejack tool with its dependencies and transitive dependencies:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@oxzi oxzi requested review from FRidh and jonringer as code owners Jul 2, 2020
@oxzi oxzi changed the title Btlejack 2.0.0 btlejack: init at 2.0.0 Jul 2, 2020
Copy link
Contributor

jonringer left a comment

try to enable unit tests for the packages if possible.

use pythonImportsCheck otherwise

log-symbols spinners cursor termcolor colorama six
];

doCheck = false;

This comment has been minimized.

@jonringer

jonringer Jul 2, 2020 Contributor

There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.

If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors.

This comment has been minimized.

@oxzi

oxzi Jul 19, 2020 Author Member

Thanks for your feedback and please excuse the delay on my side.

I have updated the PR to pythonImportsCheck the Python packages. I was not able to run the tests because those require internet access.

@oxzi oxzi force-pushed the oxzi:btlejack-2.0.0 branch from 36b4036 to 89a27ea Jul 19, 2020
@oxzi oxzi force-pushed the oxzi:btlejack-2.0.0 branch from 89a27ea to 7cc8479 Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.