Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kopia: init at 0.5.2 #94462

Merged
merged 1 commit into from Aug 5, 2020
Merged

kopia: init at 0.5.2 #94462

merged 1 commit into from Aug 5, 2020

Conversation

@bbigras
Copy link
Contributor

bbigras commented Aug 1, 2020

Motivation for this change
Things done

I only tested a "filesystem" backup for now.

Thanks to @Infinisil for the help with the "vendor" thing.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
# make 'vendor' writable
cp -L -r vendor tmp-vendor
rm -rf vendor
mv tmp-vendor vendor
Comment on lines +18 to +21

This comment has been minimized.

Copy link
@dasj19

dasj19 Aug 2, 2020

Contributor

why not just chmod +w vendor?

This comment has been minimized.

Copy link
@bbigras

bbigras Aug 2, 2020

Author Contributor

It's a symlink pointing to the nix store. I should make the comment clearer.

@dasj19
Copy link
Contributor

dasj19 commented Aug 2, 2020

Built with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 94462" and runs fine. You can thick the 3rd checkbox in the description.

@nixos-discourse
Copy link

nixos-discourse commented Aug 5, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/246

Copy link
Contributor

jonringer left a comment

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/94462
1 package built:
kopia
@jonringer jonringer merged commit 72ff02c into NixOS:master Aug 5, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="69d4984"; rev="69d49846df7285875e113364f9f40a5450badcb9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="69d4984"; rev="69d49846df7285875e113364f9f40a5450badcb9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="69d4984"; rev="69d49846df7285875e113364f9f40a5450badcb9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="69d4984"; rev="69d49846df7285875e113364f9f40a5450badcb9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="69d4984"; rev="69d49846df7285875e113364f9f40a5450badcb9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="69d4984"; rev="69d49846df7285875e113364f9f40a5450badcb9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="69d4984"; rev="69d49846df7285875e113364f9f40a5450badcb9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kopia, kopia.passthru.tests on aarch64-linux Success
Details
kopia, kopia.passthru.tests on x86_64-linux Success
Details
@bbigras
Copy link
Contributor Author

bbigras commented Aug 5, 2020

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.