Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfrotz: init at 2.52 #94463

Merged
merged 1 commit into from Aug 6, 2020
Merged

sfrotz: init at 2.52 #94463

merged 1 commit into from Aug 6, 2020

Conversation

@ddelabru
Copy link
Contributor

ddelabru commented Aug 1, 2020

sfrotz is an SDL interface version of frotz, the Z-machine interpreter which plays both Infocom games and newer games targeting the Z-machine. Unlike the curses interface version of Frotz, SDL Frotz can handle the graphics in Z-machine version 6 games.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ddelabru
Copy link
Contributor Author

ddelabru commented Aug 1, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 1, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

pkgs/games/sfrotz/default.nix Outdated Show resolved Hide resolved
pkgs/games/sfrotz/default.nix Outdated Show resolved Hide resolved
pkgs/games/sfrotz/default.nix Outdated Show resolved Hide resolved
pkgs/games/sfrotz/default.nix Outdated Show resolved Hide resolved
@srhb
Copy link
Contributor

srhb commented Aug 6, 2020

@ofborg build sfrotz

pkgs/games/sfrotz/default.nix Outdated Show resolved Hide resolved
sfrotz is an SDL interface version of frotz, the Z-machine interpreter which plays both Infocom games and newer games targeting the Z-machine. Unlike the curses interface version of Frotz, SDL Frotz can handle the graphics in Z-machine version 6 games.
@ddelabru ddelabru force-pushed the ddelabru:add-sfrotz branch from 79c39f7 to 5efc22d Aug 6, 2020
@srhb
srhb approved these changes Aug 6, 2020
Copy link
Contributor

srhb left a comment

Looks good, thank you! Just letting ofborg have another go 👍

@ddelabru
Copy link
Contributor Author

ddelabru commented Aug 6, 2020

@srhb Thanks for helping me improve! For what it's worth, I've got a pull request to update another package that builds from the same code base (the curses interface for frotz). It's #94464. A little simpler than this one.

@srhb srhb merged commit fd8e611 into NixOS:master Aug 6, 2020
17 of 18 checks passed
17 of 18 checks passed
tests tests
Details
tests tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5efc22d"; rev="5efc22d2b92a112b56672f48e94915ac0d217a1b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5efc22d"; rev="5efc22d2b92a112b56672f48e94915ac0d217a1b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5efc22d"; rev="5efc22d2b92a112b56672f48e94915ac0d217a1b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5efc22d"; rev="5efc22d2b92a112b56672f48e94915ac0d217a1b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5efc22d"; rev="5efc22d2b92a112b56672f48e94915ac0d217a1b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5efc22d"; rev="5efc22d2b92a112b56672f48e94915ac0d217a1b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5efc22d"; rev="5efc22d2b92a112b56672f48e94915ac0d217a1b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sfrotz, sfrotz.passthru.tests on aarch64-linux Success
Details
sfrotz, sfrotz.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.