Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
suitesparse: rename fixDarwinDylibNames override #96982
Motivation for this change
This seems to prevent shadowing the regular fixDarwinDylibNames function, which is a nativeBuildInput. Without this change some dylibs still had relative paths embedded. It's possible something deeper is happening, but this change fixed the issue for me. See #96981 for details.
That would be better. I don't have a Darwin machine to check, maybe @graham33 could? Still, these changes look reasonable to me, and I'm fine with merging them if they fix the problem.
This shadows the regular fixDarwinDylibNames function, which is a nativeBuildInput, and prevents it from converting some relative paths to absolute. According to the comment this can be removed as of 5.7.2.
I think we still need
vs this with
I don't know much about Darwin dylibs, but I think absolute store paths are what we want (and these were the source of the problems I had with Octave).