-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audacity: 2.4.1 -> 2.4.2 #97370
audacity: 2.4.1 -> 2.4.2 #97370
Conversation
It's different sure, but what exactly is weird? Please note that gtk2 is dead and everything that supports gtk3 will be moved over. |
@peterhoeg the dropdowns in the toolbar line beginning with "ALSA" seem to be truncated. |
Ah, that's an upstream issue: audacity/audacity#638 |
Not only truncated. Widgets and corresponding areas reacting on mouse clicks seem to be misaligned. That's not fatal, but feels very confusing. |
e71fa55
to
23b1062
Compare
Too many problems with the move to gtk3 (works OK here under KDE), so revert to gtk2 as recommended by upstream: |
building this and running it would cause a segfault for me:
The Program build localy. Maybe im holding it wrong. |
oh nvm it destroys my users fontconfig I guess. after running audacity I have to delete ~/.cache in order to use my window system again. I think this is something which was allready discussed in another issue? |
When I start it, I'm getting Fontconfig warning: "/etc/fonts/fonts.conf", line 86: unknown element "blank" ALSA lib pcm_dsnoop.c:642:(snd_pcm_dsnoop_open) unable to open slave ALSA lib pcm_dmix.c:1090:(snd_pcm_dmix_open) unable to open slave ALSA lib pcm.c:2731:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear ALSA lib pcm.c:2731:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe ALSA lib pcm.c:2731:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side ALSA lib pcm_dmix.c:1090:(snd_pcm_dmix_open) unable to open slave Cannot connect to server socket err = No such file or directory Cannot connect to server request channel jack server is not running or cannot be started JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock Expression 'stream->playback.pcm' failed in '/build/source/lib-src/portaudio-v19/src/hostapi/alsa/pa_linux_alsa.c', line: 4628 Expression 'stream->playback.pcm' failed in '/build/source/lib-src/portaudio-v19/src/hostapi/alsa/pa_linux_alsa.c', line: 4628 Expression 'stream->playback.pcm' failed in '/build/source/lib-src/portaudio-v19/src/hostapi/alsa/pa_linux_alsa.c', line: 4628 with the last pair of errors repeating very fast. The UI doesn't react. On one start it got further (shown a dialog) and segfaulted immediately. EDIT: that's with log Attempting to connect to Audacity failed...retrying Fontconfig warning: "/etc/fonts/fonts.conf", line 86: unknown element "blank" ALSA lib pcm_dsnoop.c:642:(snd_pcm_dsnoop_open) unable to open slave ALSA lib pcm_dmix.c:1090:(snd_pcm_dmix_open) unable to open slave ALSA lib pcm.c:2731:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear ALSA lib pcm.c:2731:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe ALSA lib pcm.c:2731:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side ALSA lib pcm_dmix.c:1090:(snd_pcm_dmix_open) unable to open slave Cannot connect to server socket err = No such file or directory Cannot connect to server request channel jack server is not running or cannot be started JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock Expression 'stream->playback.pcm' failed in '/build/source/lib-src/portaudio-v19/src/hostapi/alsa/pa_linux_alsa.c', line: 4628 Expression 'stream->playback.pcm' failed in '/build/source/lib-src/portaudio-v19/src/hostapi/alsa/pa_linux_alsa.c', line: 4628 Expression 'stream->playback.pcm' failed in '/build/source/lib-src/portaudio-v19/src/hostapi/alsa/pa_linux_alsa.c', line: 4628 |
So we're in a bit of a pickle here it seems.
I was running audacity with gtk3 and it was fine (apart from a few cosmetic glitches) - I'm guessing you were using the default gtk2 version @vcunat ? |
Yes, I just used the plain |
Do you mind trying this one:
(callPackage ../applications/audio/audacity { wxGTK = wxGTK31-gtk3; };)
Assuming this works, we have the following options:
1. keep 2.4.1 with gtk2 as that seems to work, or
2. update to 2.4.2 with gtk3 and accept the visual inconsistencies
In case of 1, we then just wait until upstream releases something that fully works with gtk3.
|
Appears to work OK for me. (though I almost don't use |
@peterhoeg did you get around to do more testing? I'll mark the PR WIP until I hear back from you. |
0584089
to
ea9b97d
Compare
Now we have both a gtk2 and a gtk3 variant. Still default to gtk2 until upstream gives the go-ahead. |
Note that changes in pname break |
A few other things: - prep for transition to gtk3 when audacity recommends it - we drop the runtime linking with lame as audacity is picking it up on its own - on linux, add a number of missing dependencies. - use a newer (recommended) wxwidgets - add a patch (merged upstream) that makes audacity follow XDG for file locations
Thank you. Better drop it then as we at some point would want people to upgrade from the gtk2 version to the gtk3 version.
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 2 packages built:
|
Motivation for this change
A few other things:
its own
Cc: @lheckemann
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)