Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.gym: fix dependency constraints #98591

Merged
merged 1 commit into from Oct 6, 2020
Merged

python3Packages.gym: fix dependency constraints #98591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkgs/development/python-modules/gym/default.nix
View file
Open in desktop
Expand Up @@ -14,8 +14,10 @@ buildPythonPackage rec {

postPatch = ''
substituteInPlace setup.py \
--replace "pyglet>=1.2.0,<=1.3.2" "pyglet"
--replace "pyglet>=1.2.0,<=1.3.2" "pyglet" \
--replace "cloudpickle>=1.2.0,<1.4.0" "cloudpickle~=1.2"
'';
# cloudpickle range has been expanded in package but not yet released
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future PRs, I think it would be better to have the comment before the thing you're commenting on. At least that seems to be the standard. Not important enough to hold this up though.


propagatedBuildInputs = [
numpy requests six pyglet scipy cloudpickle
Expand All @@ -24,6 +26,8 @@ buildPythonPackage rec {
# The test needs MuJoCo that is not free library.
doCheck = false;

pythonImportCheck = [ "gym" ];

meta = with lib; {
description = "A toolkit by OpenAI for developing and comparing your reinforcement learning agents";
homepage = "https://gym.openai.com/";
Expand Down