Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aldo: 0.7.7 -> 0.7.8 #99444

Merged
merged 1 commit into from Oct 28, 2020
Merged

aldo: 0.7.7 -> 0.7.8 #99444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 11 additions & 6 deletions pkgs/applications/radio/aldo/default.nix
View file
Open in desktop
@@ -1,14 +1,19 @@
{ stdenv, fetchurl, libao }:
{ stdenv, fetchgit, libao, autoreconfHook }:

stdenv.mkDerivation rec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a particular reason for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to not have recursive attribute sets where variables can be borrowed and used anywhere, it makes the scope more confusing than a let block :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, not a style I see often. Thanks for explaining!

let
pname = "aldo";
version = "0.7.7";
version = "0.7.8";
in stdenv.mkDerivation {
inherit pname version;

src = fetchurl {
url = "mirror://savannah/${pname}/${pname}-${version}.tar.bz2";
sha256 = "14lzgldqzbbzydsy1cai3wln3hpyj1yhj8ji3wygyzr616fq9f7i";
src = fetchgit {
url = "git://git.savannah.gnu.org/${pname}.git";
rev = "v${version}";
sha256 = "0swvdq0pw1msy40qkpn1ar9kacqjyrw2azvf2fy38y0svyac8z2i";
};

nativeBuildInputs = [ autoreconfHook ];

buildInputs = [ libao ];

meta = with stdenv.lib; {
Expand Down