Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.domain-auth: disable test suite #99641

merged 1 commit into from Oct 6, 2020


Copy link

@malte-v malte-v commented Oct 5, 2020

Motivation for this change

Fix the build for haskellPackages.domain-auth.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Copy link

@cdepillabout cdepillabout commented Oct 6, 2020

@malte-v Could you send this PR to the haskell-updates branch (and change the base branch here on github as well?)

@malte-v malte-v force-pushed the fix-domain-auth branch from 604e74f to 6fe0721 Oct 6, 2020
@malte-v malte-v changed the base branch from master to haskell-updates Oct 6, 2020
Copy link
Contributor Author

@malte-v malte-v commented Oct 6, 2020

I think I did what you mean.

Copy link

@cdepillabout cdepillabout commented Oct 6, 2020

Looks good, thanks for fixing this!

@cdepillabout cdepillabout merged commit 277ace0 into NixOS:haskell-updates Oct 6, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants