Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback] Support for other grammar files? + Error display #1

Closed
TheWitheredStriker opened this issue Jul 4, 2022 · 3 comments
Closed
Labels
enhancement New feature or request implemented This feature has been added

Comments

@TheWitheredStriker
Copy link

Hello!

Was wondering if you could potentially consider adding support for non-YAML-based grammar files at some point in the future (like JSON, CSON, XML etc). It's a bit irritating having to try to either find YAML grammars or having to try to convert other grammars (which doesn't work for me).

It'd also be useful to have some sort of "marker" that appears when NL fails to highlight the grammar (e.g. dysfunctional grammar file). Right now, nothing appears at all when you click the button and it doesn't work, which is not too clear imo.

Thanks again for making this!

@Nixinova
Copy link
Owner

Apologies for the late reply, I missed this notif.
This project uses web ESM modules and I remember trying to get a converter but the npm packages didn't seem to work when loaded in the browser.
I will have another look at finding a package that can do this, as I can tell that converting manually would be quite annoying.

Nixinova added a commit that referenced this issue Jul 21, 2022
Nixinova added a commit that referenced this issue Jul 21, 2022
Nixinova added a commit that referenced this issue Jul 21, 2022
@Nixinova Nixinova added enhancement New feature or request implemented This feature has been added labels Jul 21, 2022
Nixinova added a commit that referenced this issue Jul 21, 2022
@Nixinova
Copy link
Owner

Try it out now, it should support JSON + CSON + PLIST now 👍

@TheWitheredStriker
Copy link
Author

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implemented This feature has been added
Projects
None yet
Development

No branches or pull requests

2 participants