Fix/page load typo mistake #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…template/app/js/main.js as the reference to the pages object/array was missing an s at the end at line 490 of main.js
…page-load-typo-mistake
|
Thanks @DanDvoracek. I've merged and release this fix as version 1.8.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR cover?
I noticed a bug when I tried to load a page first. I only touched two files. main.js (and main.min.js simply to make sure). I simply added an "s" at the end of the reference to an object.
How can this be tested?
Remove the "s" from _this.content.pages on line 490 of main.js (Description in my commit)
What gif best describes how you feel about this work?
As it's my first contribution to an open source project ever, I would say this one
Reviewers
Review 1
Review 2 (optional)
By adding a +1 you are confirming you have...