-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolving module_path with __dirname #96
resolving module_path with __dirname #96
Conversation
@NonPolynomial Thanks for this. I haven't had chance to test on a Mac yet but it looks good. |
@RyanHavoc I have to thank you, I'm glad that I can contribute some to this awesome tool 👍 |
Any way that this could get merged, @RyanHavoc? :) Also, thanks for this, @NonPolynomial. I think I would have picked it up otherwise, but you were faster. :) |
Good question, I also pitched in in this fix and made a Pull Request in @NonPolynomial 's branch removing unnecessary dependencies ("global-modules") after resolving the path relatively, see https://github.com/NonPolynomial/astrum/pull/1 I'd also like to point out that this fix resolves issue #116 as well, enabling astrum users to install it locally, for example as a dev dependency, which is great for CI environments or usage with containers, not having to install the library globally in the image as well. |
I tested the functionality in a Windows 7 VM and macOS Sierra successfully. |
Hey @giothevanni , thanks for your further work on this fix!
Hey guys, i merged the commit from @giothevanni into my repo. This should work now for Win 7, 8.1 and 10, and also on MacOS Sierra - thanks to @giothevanni for further fixes and testing. FYI @RyanHavoc |
@NonPolynomial @giothevanni Thanks for the work on this guys! Released it as 1.9.5. |
Thank you all, this was way faster than I expected. :) Setting it up locally now. Cheers! 🍻 |
@RyanHavoc How is the progress on Release v2.0.0? Are those changes from @giothevanni and me conflicting with the current state of release/2.0.0 ? |
What does this PR cover?
Fixing the issue #64.
path
- module inmanager/utils.js
__dirname
How can this be tested?
Initialize astrum pattern llibrary in arbitary folder (e.g.
astrum init ./pttrns/
)Screenshots / Screencast
Reviewers
Review 1
Review 2 (optional)
By adding a +1 you are confirming you have...