Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email template generates broken image links #5522

Closed
RoiEXLab opened this issue Mar 11, 2017 · 1 comment
Closed

Email template generates broken image links #5522

RoiEXLab opened this issue Mar 11, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@RoiEXLab
Copy link
Contributor

Was noticing this for a while now...
Email templates basically retrieve the post HTML by using {postBody} inside the template file.
This inserts HTML when being processed with the correct image tags, but without the base_url appended to those tags!
For example:

SomePost Text
SomeImage:
<img src="/assets/uploads/files/somefilename.png">

is generated instead of

SomePost Text
SomeImage:
<img src="{base_url}/assets/uploads/files/somefilename.png">

While looking at the post html on the website the base_url can easily be omitted, but when viewing using you mail client, this mail client can't know about the server...

@pitaj pitaj added the bug label Apr 23, 2017
@joolswills
Copy link

joolswills commented May 7, 2017

Have had a user report this on our forum - https://retropie.org.uk/forum/topic/10095/forum-subscription-emails-broken-images

Just something that's bugging me and maybe a config thing: any images in a post are placed in the email html, but have the wrong source url. Eg, something like:

http:///forum/assets/uploads/files/1493925908207-nes-mini-new-carousel-2-resized.png

it looks like it's missing the retropie.org.uk part. Perhaps something in the board config?

(Just in case a confirmation / another example is useful).

@barisusakli barisusakli self-assigned this May 28, 2017
@barisusakli barisusakli added this to the 1.5.1 milestone May 28, 2017
barisusakli added a commit that referenced this issue May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants