Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The masonry.js not loaded if page refreshes directly #6344

Closed
georgezhang opened this issue Mar 6, 2018 · 2 comments
Closed

The masonry.js not loaded if page refreshes directly #6344

georgezhang opened this issue Mar 6, 2018 · 2 comments
Assignees
@julianlam @barisusakli
Labels
bug
Milestone
1.10.0

Comments

@georgezhang
Copy link

georgezhang commented Mar 6, 2018 •
edited
Loading

  • NodeBB version:
    v1.7.x
  • NodeBB git hash:

7df1914

  • Database type: mongo or redis
    mongo
  • Database version:

3.2.9

  • Exact steps to cause this issue:
  1. Activate plugin nodebb-theme-lavender;
  2. create multiple categories and topics;
  3. Access to http://localhost:4567/categories directly from URL in browser.
    More detail on https://community.nodebb.org/topic/11983/the-masonry-js-not-loaded-if-page-refreshes-directly
  • What you expected:

Masonry effect should apply like clicking Categories Button on navigation.

  • What happened instead:

The masonry.js or its initial script was skipped. Masonry effect doesn't seems to be applied.
georgezhang added a commit to georgezhang/nodebb-theme-lavender that referenced this issue Mar 6, 2018
@georgezhang
fixed The masonry.js not loaded
af729be 
Problem reported:
NodeBB/NodeBB#6344
https://community.nodebb.org/topic/11983/the-masonry-js-not-loaded-if-page-refreshes-directly/3
georgezhang added a commit to georgezhang/nodebb-theme-lavender that referenced this issue Mar 6, 2018
@georgezhang
doMasonry when page load or reload
9ceda59 
temporary fix for https://community.nodebb.org/topic/11983/the-masonry-js-not-loaded-if-page-refreshes-directly/4 or NodeBB/NodeBB#6344
@pichalite
Copy link
Contributor

pichalite commented Mar 8, 2018 •
edited
Loading

@georgezhang This issue needs to be posted here https://github.com/NodeBB/nodebb-theme-lavender/issues

@julianlam
Copy link
Member

@georgezhang Can you submit a pull request with the above commits?

@julianlam julianlam self-assigned this Mar 9, 2018
@julianlam julianlam added this to the 1.8.0 milestone Mar 9, 2018
@julianlam julianlam added the bug label Mar 9, 2018
@julianlam julianlam modified the milestones: 1.8.0, 1.9.0 Mar 15, 2018
@georgezhang georgezhang mentioned this issue Mar 16, 2018
Closed
@julianlam julianlam modified the milestones: 1.8.1, 1.8.2 Mar 21, 2018
@julianlam julianlam modified the milestones: 1.8.2, 1.8.3 Apr 4, 2018
@barisusakli barisusakli modified the milestones: 1.8.3, 1.9.0 Apr 5, 2018
@julianlam julianlam modified the milestones: 1.9.0, 1.9.1 May 2, 2018
@julianlam julianlam modified the milestones: 1.9.1, 1.9.2 May 10, 2018
@barisusakli barisusakli modified the milestones: 1.9.2, 1.9.3, 1.9.4 May 18, 2018
@barisusakli barisusakli modified the milestones: 1.9.4, 1.10.0 May 30, 2018
@barisusakli barisusakli self-assigned this Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julianlam julianlam

@barisusakli barisusakli

Labels
bug
Projects
None yet
Milestone
1.10.0
Development

No branches or pull requests
4 participants
@georgezhang @julianlam @barisusakli @pichalite