Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users do not receive mentions if the mention is entered during a post edit #6350

Closed
julianlam opened this issue Mar 10, 2018 · 2 comments
Closed

Users do not receive mentions if the mention is entered during a post edit #6350

julianlam opened this issue Mar 10, 2018 · 2 comments
Assignees
@julianlam
Labels
enhancement
Milestone
1.10.2

Comments

@julianlam
Copy link
Member

  • NodeBB version: v1.8.0
  • NodeBB git hash: 9ea6dbc
  • Database type: both
  • Database version: N/A
  • Exact steps to cause this issue:
1. Create a post with no mentions
1. Edit the post and add a mention
  • What you expected:
- I expected the mentioned user to receive a notification
  • What happened instead:
- No notification was given

This issue became much easier to resolve now that we have post editing history. Now the history can be examined and new mentions can be processed.
@julianlam julianlam added this to the 1.9.0 milestone Mar 10, 2018
@julianlam julianlam self-assigned this Mar 10, 2018
@julianlam julianlam modified the milestones: 1.8.1, 1.8.2 Mar 21, 2018
@julianlam julianlam modified the milestones: 1.8.2, 1.8.3 Apr 4, 2018
@barisusakli barisusakli modified the milestones: 1.8.3, 1.9.0 Apr 5, 2018
@julianlam julianlam modified the milestones: 1.9.0, 1.9.1 May 2, 2018
@julianlam julianlam modified the milestones: 1.9.1, 1.9.2 May 10, 2018
@barisusakli barisusakli modified the milestones: 1.9.2, 1.9.3, 1.9.4 May 18, 2018
@barisusakli barisusakli modified the milestones: 1.9.4, 1.10.0 May 30, 2018
@barisusakli barisusakli modified the milestones: 1.10.0, 1.10.1 Jun 26, 2018
@julianlam julianlam modified the milestones: 1.10.1, 1.10.2 Jul 5, 2018
@julianlam
Copy link
Member Author

Mentions v2.2.9

julianlam added a commit to julianlam/nodebb-plugin-mentions that referenced this issue Oct 4, 2018
@julianlam
Update logic for NodeBB/NodeBB#6350
d32494a 
Use sorted set instead of list... I'm a little overzealous when
finding use cases for lists...
@julianlam julianlam reopened this Oct 4, 2018
julianlam added a commit to julianlam/nodebb-plugin-mentions that referenced this issue Oct 4, 2018
@julianlam
Update logic for NodeBB/NodeBB#6350 (#103)
29f8e38 
* Update logic for NodeBB/NodeBB#6350

Use sorted set instead of list... I'm a little overzealous when
finding use cases for lists...

* simplified code
@julianlam
Copy link
Member Author

v2.2.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julianlam julianlam

Labels
enhancement
Projects
None yet
Milestone
1.10.2
Development

No branches or pull requests
2 participants
@julianlam @barisusakli