make upgrade script names unique

[barisusakli]

Right now it is possible to create upgrade scripts with duplicates which would cause the script to not run at all.

[julianlam]

Writing a test? 😛

[barisusakli]

I don't even know if this is fixable because all the upgrade scripts are already in schemaLog like this

{ "_key" : "schemaLog", "value" : "remove_flag_reporters_zset", "score" : 1596214542878 }
{ "_key" : "schemaLog", "value" : "consolidate_flags", "score" : 1595616104011 }
{ "_key" : "schemaLog", "value" : "track_flags_by_target", "score" : 1595119081284 }
{ "_key" : "schemaLog", "value" : "readd_deleted_recent_topics", "score" : 1594226733929 }
{ "_key" : "schemaLog", "value" : "unescape_navigation_titles", "score" : 1593293879622 }
{ "_key" : "schemaLog", "value" : "fix_category_image_field", "score" : 1591729494708 }
{ "_key" : "schemaLog", "value" : "remove_allowFileUploads_priv", "score" : 1590110492477 }
{ "_key" : "schemaLog", "value" : "fix_users_sorted_sets", "score" : 1588436379784 }
{ "_key" : "schemaLog", "value" : "clean_post_topic_hash", "score" : 1570504049203 }
{ "_key" : "schemaLog", "value" : "cleanup_old_notifications", "score" : 1570502545917 }
{ "_key" : "schemaLog", "value" : "notification_type_new_topic", "score" : 1570036597733 }
{ "_key" : "schemaLog", "value" : "missing_langhub_sets", "score" : 1569982274463 }
{ "_key" : "schemaLog", "value" : "remove_long_suggested_tags", "score" : 1569981625594 }
{ "_key" : "schemaLog", "value" : "clean_flag_byCid", "score" : 1569367219940 }
{ "_key" : "schemaLog", "value" : "give_mod_info_privilege", "score" : 1568747522553 }
{ "_key" : "schemaLog", "value" : "dbsearch_change_mongodb_schema", "score" : 1566520649272 }
{ "_key" : "schemaLog", "value" : "user_pid_sets", "score" : 1561471090625 }
{ "_key" : "schemaLog", "value" : "update_registration_type", "score" : 1561176751497 }
{ "_key" : "schemaLog", "value" : "give_mod_privileges", "score" : 1561176751494 }

Where the value is the filename of the upgrade script. Making any change to this logic would cause all upgrade scripts to run again which would probably break on most forums.

Might have to start using the version name as part of the filename for upgrade scripts from now on. So instead of some_new_upgrade_script.js it should be 1.5.0_some_new_upgrade_script.js that way it won't overwrite anything in schemaLog

[pitaj]

Why not just keep naming them how we are and adding a test to make sure no two scripts have the same name?

[barisusakli]

Went with something else.
8887f0e

[pitaj]

Does that solution get executed during tests?

[barisusakli]

There were no tests for upgrades, added one to cover this.