Use a BCP 47-compliant language tag for Pirate

[BenLubar]

[pitaj]

You can probably achieve the same result by putting en@pirate alongside en_US in the prepareDOM function in the translator

[julianlam]

Looks good to me... what does en-x-pirate do anyway in .toLocaleString(), one wonders.

Not going to lie, was hoping for a y'arr or two.

[julianlam]

@pitaj brings up a good point in that we are now maintaining two mappings:

• NodeBB/Transifex to timeago (mapping in translator.js)
• NodeBB to BCP 47 (currently just the .replace('_', '-');)

Prior to merging, I'd like to investigate whether we can eliminate one or the other...

[BenLubar]

The timeago locales could be changed into a single JSON file where the keys are looked up via the BCP 47 tag with a fallback to the BCP 47 tag with the first hyphen and everything after it removed.

[pitaj]

Yeah there's a lot of things that could be changed with regards to that
method. The best solution is to just rename all NodeBB locales to the
standard format.

On Nov 18, 2016 09:41, "Ben Lubar" notifications@github.com wrote:

The timeago locales could be changed into a single JSON file where the
keys are looked up via the BCP 47 tag with a fallback to the BCP 47 tag
with the first hyphen and everything after it removed.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5214 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAxDddsKk77VnNeIqnturpVfnL6jbjqaks5q_dUvgaJpZM4K13bX
.

[julianlam]

Looks like this PR is deprecated in favour of #5218