feat: more discrete commit-on-save instead of commit-on-change w/ confirm modals #8541
Conversation
- new language strings for confirmation and success modals/toasts - indeterminate privilege handling (/cc @psychobunny) - added new discard button - both discard and save buttons now have confirmation dialogs
|
A better view of the new privilege setting hints... green check for staged addition, red outline for staged removal, and red dash for staged removal (but indeterminate privilege still applies) |
|
So what's the difference between the types of staged removal? |
|
Nothing, it simply denotes the privilege that will be set or removed, once you hit save. |
|
Wait now I'm more confused. Why are there two types of staged removal? |
|
There aren't. It's just showing that it's an inherited privilege, so removing it won't do anything.
…On Sun, Aug 2, 2020, at 16:15, Peter Jaszkowiak wrote:
Wait now I'm more confused. Why are there two types of staged removal?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub <#8541 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHBLAZF7H5WSZTZ3OYVZHTR6XCOBANCNFSM4PREUZ4A>.
|
|
Was out when you commented... basically, there are two kinds of privileges, same as before. Either it's applied, or not. However, we added the inherited privilege just as a way to explain to admins that because e.g. So that's why we use the indeterminate checkbox state; the dashed input. The new colouring simply signals to the admin that the changes have not been applied yet, that is all 😄 |
Also, ability to add user to a privilege table without needing to refresh the privilege table.
breaking: helpers.getUserPrivileges and helpers.getGroupPrivileges no longer make socket calls to the following hooks: - filter:privileges.list, filter:privileges.admin.list, filter:privileges.global.list, filter:privileges.groups.list, filter:privileges.admin.groups.list, filter:privileges.gloval.groups.list The filters are still called, but done before the helper method is called, and the results are passed in instead. This change should only affect you if you directly call the helper methods, otherwise the change is transparent.
Small UI hints when privileges changes are staged (but not committed/saved)
New save/discard buttons
