Disabling notifications #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 21, 2020 13:08
… feature/disabling-notifications
nmlinaric
approved these changes
Feb 24, 2020
morrigan
requested changes
Feb 25, 2020
There was a problem hiding this comment.
This is fine but we are missing an additional endpoint for disabling notifications that frontend can use.
This can be a separate endpoint or use the existing endpoint for editing node (better). The existing endpoint for updating node is PUT "/user/node"which then needs renaming and expanding to support updating notifications settings too.
nmlinaric
approved these changes
Feb 25, 2020
morrigan
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #48