This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Possible heap overflow: Cancelled orders are not removed #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The following code generates a heap overflow:
Why:
Every iteration of the while loop appends a new
order
object to thepushes
array ofrandomOtherChannel
. Theorder
immediately get’s cancelled but is never removed from the array. It should normally be skipped insidematchPushesAndShifts()
and then sliced off insideprocessOrders()
. This never happens because the while loop condition insidematchPushesAndShifts()
is never met (theshifts
array ofrandomOtherChannel
is always empty).Solution:
Filter out all cancelled orders from
pushes
andshifts
at the end of everyprocessOrders()
call.