Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add color to scorecard menu #253

Merged
merged 2 commits into from
Nov 25, 2023
Merged

feat: add color to scorecard menu #253

merged 2 commits into from
Nov 25, 2023

Conversation

fraxken
Copy link
Member

@fraxken fraxken commented Nov 25, 2023 •
edited
Loading

image
image
image
image

@fraxken fraxken marked this pull request as ready for review November 25, 2023 13:36
PierreDemailly
PierreDemailly approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@PierreDemailly PierreDemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.5 is a bit strict imo
Because it's hard to have a good note, for instance i would see green for a package that is 8.2
But it's ok anyway, we can change later if needed, lgtm

@fraxken fraxken merged commit c64d133 into master Nov 25, 2023
9 checks passed
@fraxken fraxken deleted the scorecard-color branch November 25, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreDemailly PierreDemailly PierreDemailly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fraxken @PierreDemailly