Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ci #94

Merged
merged 7 commits into from
Dec 22, 2021
Merged

chore: fix ci #94

merged 7 commits into from
Dec 22, 2021

Conversation

tony-go
Copy link
Member

@tony-go tony-go commented Dec 14, 2021

Tryin to work on a new feature (check version). I figured that test was broken on master but green on the CI.

TODO:

  • fix ci
  • fix tests

@targos
Copy link
Collaborator

targos commented Dec 14, 2021

Just curious, what CI failure are you trying to fix? GitHub actions are green on master.

@tony-go
Copy link
Member Author

tony-go commented Dec 14, 2021

Just curious, what CI failure are you trying to fix? GitHub actions are green on master.

It's green in the CI but tests within fail...

@tony-go
Copy link
Member Author

tony-go commented Dec 14, 2021

Now, that CI fails as expected, I'll attempt to fix tests now 😅

@targos
Copy link
Collaborator

targos commented Dec 14, 2021

Just curious, what CI failure are you trying to fix? GitHub actions are green on master.

It's green in the CI but tests within fail...

haha no need for the volkswagen module in this project :D

@tony-go
Copy link
Member Author

tony-go commented Dec 15, 2021

Friendly ping @fraxken

@tony-go tony-go requested a review from targos December 22, 2021 18:20
@fraxken fraxken merged commit 116c5fe into NodeSecure:master Dec 22, 2021
@tony-go tony-go deleted the fix-ci branch December 22, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants