Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(probeRunner): assert probes method in proberunner #204

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

tchapacan
Copy link
Contributor

@tchapacan tchapacan commented Jan 14, 2024

// TODO: https://github.com/NodeSecure/js-x-ray/blob/master/src/ProbeRunner.js#L74

Assert probes method in probeRunner constructor

Purpose of this PR is to :

  • assert that validateNode is a function or array of functions
  • assert that main is a function
  • add unittest

Note that i have used import assert from "node:assert"; in probeRunner class but same can be done using if conditional.
LMK if it seems ok and enough to cover this TODO in probeRunner class ? I can assert that name exist as well ?

If anyone want to participate/feedback/propose/improve solution don't hesitate!

@tchapacan tchapacan marked this pull request as ready for review January 16, 2024 21:21
@fraxken fraxken merged commit d9cf1f2 into NodeSecure:master Jan 17, 2024
7 checks passed
@fraxken
Copy link
Member

fraxken commented Jan 17, 2024

@allcontributors please add @tchapacan for code, test

Copy link
Contributor

@fraxken

I've put up a pull request to add @tchapacan! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants