Report.isOneLineRequire should be true if single line LogicalExpression assignment #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of a LogicalExpression
PierreDemailly
approved these changes
Jan 17, 2024
fraxken
reviewed
Jan 17, 2024
Co-authored-by: Thomas.G <gentilhomme.thomas@gmail.com>
…least one require
fraxken
approved these changes
Jan 17, 2024
PierreDemailly
approved these changes
Jan 17, 2024
This was referenced Jun 5, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: After exchanges with @fraxken, we need to check the LogicalExpression (left, right) and
ConditionalExpression(consequent, alternate).This pull request addresses issue #168.
I added an AST check to ensure that files containing only one line and composed of a
LogicalExpressionassignation, typically an export:module.exports = require('fs') || require('constants'), are considered as not minified.