feat: create getVulnerabilities function #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathieuka
force-pushed
the
decoupling-with-scanner
branch
2 times, most recently
from
555ab7d
to
271e926
Compare
Mathieuka
changed the title
Mathieuka
changed the title
Mathieuka
changed the title
Mathieuka
force-pushed
the
decoupling-with-scanner
branch
from
271e926
to
46f64a5
Compare
Mathieuka
force-pushed
the
decoupling-with-scanner
branch
from
550a96f
to
4f16299
Compare
fraxken
reviewed
May 21, 2022
Mathieuka
force-pushed
the
decoupling-with-scanner
branch
from
fcd1632
to
427443d
Compare
|
Seems globally ok to me, however the update to Defintion break other types. I guess you also need to check api.d.ts and update it like this: declare function setStrategy<T>(name?: Strategy.Kind, options?: Strategy.Options): Promise<Strategy.Definition<T>>;
declare function getStrategy<T>(): Promise<Strategy.Definition<T>>; |
Mathieuka
force-pushed
the
decoupling-with-scanner
branch
from
427443d
to
af57361
Compare
|
@all-contributors please add @Mathieuka for code |
|
I've put up a pull request to add @Mathieuka! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #28
The purpose is to start decoupling the package with
ScannerFor
NPMstrategy we have implemented thegetVulnerabilitiesfunction who return the vulnerabilities fromarboristpackage.All others strategies (security-wg, snyk, sonatype) have the function
getVulnerabilitiesbut not implemented.Add tests.
Add Documentation.