Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FacebookOAuth2Service.php #63

Closed
wants to merge 1 commit into from
Closed

Update FacebookOAuth2Service.php #63

wants to merge 1 commit into from

Conversation

vbuchyn
Copy link

@vbuchyn vbuchyn commented Oct 20, 2015

Service::checkError() returns error.
protected function checkError()
{
if (isset($_GET[$this->errorParam])) {
$error_code = $_GET[$this->errorParam];
// HERE $this->errorParam == '200', must be 'access_denied' ;
if ($error_code === $this->errorAccessDeniedCode) {
// access_denied error (user canceled)
$this->cancel();
} else {
$error = $error_code;
if (isset($_GET[$this->errorDescriptionParam])) {
$error = $_GET[$this->errorDescriptionParam] . ' (' . $error . ')';
}
throw new ErrorException($error);
}
return false;
}

    return true;
}

Service::checkError()  returns error. 
protected function checkError()
	{
		if (isset($_GET[$this->errorParam])) {
			$error_code = $_GET[$this->errorParam]; // HERE $this->errorParam = '200', must be 'access_denied' ; 
			if ($error_code === $this->errorAccessDeniedCode) {
				// access_denied error (user canceled)
				$this->cancel();
			} else {
				$error = $error_code;
				if (isset($_GET[$this->errorDescriptionParam])) {
					$error = $_GET[$this->errorDescriptionParam] . ' (' . $error . ')';
				}
				throw new ErrorException($error);
			}
			return false;
		}

		return true;
	}
@Nodge Nodge closed this in f38eca2 Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant