Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate try-runtime feature in favor of new CLI from Parity #770

Merged
merged 15 commits into from
Aug 29, 2023

Conversation

ETeissonniere
Copy link
Member

@ETeissonniere ETeissonniere commented Aug 29, 2023

  • confirm try-runtime actually works as intended
  • remove try-runtime command
  • check if we need to maintain or remove the try-runtime feature flags in the runtime

@ETeissonniere ETeissonniere changed the title replace feature flag with try runtime cli deprecate try-runtime feature in favor of new CLI from Parity Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2ef7e22) 64.87% compared to head (536957d) 64.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #770   +/-   ##
=======================================
  Coverage   64.87%   64.87%           
=======================================
  Files          40       40           
  Lines        6072     6072           
=======================================
  Hits         3939     3939           
  Misses       2133     2133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NodleCode NodleCode deleted a comment from github-actions bot Aug 29, 2023
@NodleCode NodleCode deleted a comment from github-actions bot Aug 29, 2023
@NodleCode NodleCode deleted a comment from github-actions bot Aug 29, 2023
@ETeissonniere ETeissonniere force-pushed the chores/update-to-new-try-runtime branch from ed3b331 to abf547e Compare August 29, 2023 04:06
@aliXsed
Copy link
Contributor

aliXsed commented Aug 29, 2023

@ETeissonniere I wonder how this way of calling try-runtime can actually run the pre_upgrade and post_upgrade tests that we only build for the try-runtime feature: #[cfg(feature = "try-runtime")]? For a recent example of that, have a look at here.

@ETeissonniere
Copy link
Member Author

@ETeissonniere I wonder how this way of calling try-runtime can actually run the pre_upgrade and post_upgrade tests that we only build for the try-runtime feature: #[cfg(feature = "try-runtime")]? For a recent example of that, have a look at here.

We still test with a try runtime enabled runtime and as such the right code can still be run. See below:

      # This build the runtime with try-runtime turned on
      - name: Cargo build
         run: cargo build --release --features=try-runtime -p runtime-eden
       # [... abbreviated ...]
       # Note how `--runtime` point towards the runtime we just built
       - name: Try runtime reuse snap
         run: |
             cat snapshots/created_at
             try-runtime --runtime target/release/wbuild/runtime-eden/runtime_eden.wasm on-runtime-upgrade --checks=all snap --path snapshots/eden-snapshot-full

.github/workflows/ci.yml Outdated Show resolved Hide resolved
aliXsed
aliXsed previously approved these changes Aug 29, 2023
Copy link
Contributor

@aliXsed aliXsed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, I have left only one minor comment, but it's now in a good shape.

@ETeissonniere ETeissonniere enabled auto-merge (squash) August 29, 2023 22:09
@ETeissonniere ETeissonniere merged commit defb923 into master Aug 29, 2023
6 checks passed
@ETeissonniere ETeissonniere deleted the chores/update-to-new-try-runtime branch August 29, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants