-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate try-runtime feature in favor of new CLI from Parity #770
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #770 +/- ##
=======================================
Coverage 64.87% 64.87%
=======================================
Files 40 40
Lines 6072 6072
=======================================
Hits 3939 3939
Misses 2133 2133 ☔ View full report in Codecov by Sentry. |
ed3b331
to
abf547e
Compare
@ETeissonniere I wonder how this way of calling try-runtime can actually run the pre_upgrade and post_upgrade tests that we only build for the try-runtime feature: |
We still test with a try runtime enabled runtime and as such the right code can still be run. See below:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, I have left only one minor comment, but it's now in a good shape.
try-runtime
actually works as intendedtry-runtime
commandtry-runtime
feature flags in the runtime