fix: range create error #584
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the https://github.com/NomicFoundation/hardhat-vscode/releases/tag/v0.8.4 release with the latest Slang fixes, we can now bump up the release flags to 20%.
If the import completion is triggered by deleting a quote on an existing import and readding it then, the position is the start of the import but we delete the entire length of the import line which creates a negative position triggering the bug. Instead, we short circuit. If the import is already the suggestion we don't suggest it again. Fixes #150.
OmarTawfik
approved these changes
Aug 16, 2024
OmarTawfik
force-pushed
the
development
branch
from
fea62ff
to
ccef666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the import completion is triggered by deleting a quote on an existing import and readding it then, the position is the start of the import but we delete the entire length of the import line which creates a negative position triggering the bug.
Instead, we short circuit. If the import is already the suggestion we don't suggest it again.
Fixes #150.