Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate our naming around arguments, options, parameters and parameters definition #5420

Closed
2 tasks done
alcuadrado opened this issue Jun 20, 2024 · 0 comments
Closed
2 tasks done
Assignees
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task

Comments

@alcuadrado
Copy link
Member

alcuadrado commented Jun 20, 2024

We need a follow-up PR to #5417 to finish this effort

There are a few things that still need a bit of work:

  • Let's use Argument everywhere instead of Parameter. We currently use Argument and Parameter as two different concepts. Argument being the real parameter (compsci lingua for, the actual value that you pass) and Parameter being the formal parameter (the variable that "receives" that parameter). That may be correct, but it's not obvious, and most people use it interchangeably.
  • Sometimes, we do have to refer to concepts similar to Parameter (e.g., TaskParameter). Let's use Definition as suffix in those cases. (e.g. TaskArgumentDefinition in that case). This way we make it clear that it's the "formal parameter".
@alcuadrado alcuadrado added the v-next A Hardhat v3 development task label Jun 20, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jun 20, 2024
@alcuadrado alcuadrado mentioned this issue Jun 20, 2024
6 tasks
@schaable schaable self-assigned this Jul 1, 2024
@schaable schaable closed this as completed Jul 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Archived in project
Development

No branches or pull requests

2 participants