Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs fixes #3464

Merged
merged 6 commits into from Dec 27, 2022
Merged

Docs fixes #3464

merged 6 commits into from Dec 27, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 27, 2022

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

Just a bunch of issues I found while reading the docs.

Felix added 6 commits December 25, 2022 13:36
This is the recommended way to exit with an error code.
Scripts should go in the `scripts` directory.
Self-explanatory.
`contracts` goes before `hardhat.config.js`.
The word 'to' was missing in the sentence.
.bashrc is a bash-specific file.
@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2022

⚠️ No Changeset found

Latest commit: 274f031

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 27, 2022 at 9:36AM (UTC)
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 27, 2022 at 9:36AM (UTC)

@fvictorio
Copy link
Member

Thank you!

@fvictorio fvictorio merged commit 8446209 into NomicFoundation:main Dec 27, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 27, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Hardhat Contributor:

GitPOAP: 2022 Hardhat Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant