This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fix attribute error when upgrading via dfu serial #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Even if the serial number key exists, it's value can be None. This raises a AttributeError when .lower() is called on NoneType. Quick solution is to use get() on kwargs. This returns None if the key doesn't exist or it's value is None. Signed-off-by: Guðni Már Gilbert <gudni.m.g@gmail.com>
|
We do do not have capacity to maintain and release new versions of this utility. The SDFU feature is moved into a new utility with the same name. The utility can be found here: https://www.nordicsemi.com/Products/Development-tools/nrf-util |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #393
Even if the serial number key exists, it's value can be
None. This raises aAttributeErrorwhen.lower()is called onNoneType.Quick solution is to use
get()on kwargs. This returns None if the key doesn't exist or it's value isNone.Without this fix I am unable to upgrade by BLE dongle. But with this fix, upgrading is successful.