Reconfigure proxy on network interface delete events from kernel #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InterfaceMonitor from now on sends on netlink events when an NSM inteface was deleted. Thus, proxy can reconfigure its nexthop routes (towards LBs) if the interface is known to it. Hence, nexthop routes won't linger on if the network inteface was removed from the kernel before the associated NSM connection could have been closed.
|
/reverify |
LionelJouin
reviewed
Apr 19, 2024
pkg/kernel/interface.go
Outdated
Comment on lines
157
to
158
| copy(tmpa, tmpa) | ||
| copy(tmpb, tmpb) |
There was a problem hiding this comment.
Suggested change
| copy(tmpa, tmpa) | |
| copy(tmpb, tmpb) | |
| copy(tmpa, a) | |
| copy(tmpb, b) |
?
pkg/kernel/interface.go
Outdated
| @@ -136,7 +136,35 @@ func (intf *Interface) RemoveLocalPrefix(prefix string) error { | |||
| } | |||
|
|
|||
| func (intf *Interface) Equals(iface networking.Iface) bool { | |||
| return reflect.DeepEqual(intf, iface) | |||
| if intf.index != iface.GetIndex() { | |||
There was a problem hiding this comment.
Both conditions (Index and type) could be combined. Maybe the name should be added?
LionelJouin
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The so called nsm interfaceMonitor that is used by the Proxy for both its NSC and NSE connections from now on
forwards kernel originated interface delete events. This allows the Proxy to clean-up even if the network interface was no longer available by the time the associated NSM connection got closed.
(Thus, nexthop routes towards LBs can be removed in such cases.)
Note: Order of IP addresses in the IPContext might change between periodic NSM connection refreshes. Therefore, networking.Iface items must be compared by taking the above into consideration.
Issue link
#517
Checklist