Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(submission_api): allow students to view output of CE submissions #202

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

Bogay
Copy link
Member

@Bogay Bogay commented Mar 19, 2023

Backend part of Normal-OJ/Normal-OJ#35

@Bogay Bogay requested review from uier and ra890927 March 19, 2023 14:50
@Bogay Bogay requested a review from as535364 as a code owner March 19, 2023 14:50
mongo/submission.py Outdated Show resolved Hide resolved
@Bogay Bogay force-pushed the feat/allow-view-CE-stderr branch from 3c0c989 to 6e78249 Compare March 20, 2023 13:49
@Bogay Bogay marked this pull request as draft April 23, 2023 18:56
@Bogay
Copy link
Member Author

Bogay commented Apr 23, 2023

根據之前和 @as535364 的討論,可能會多加上允許部分測資公開(不論 CE 與否)的功能,討論完成前先改 Draft。

@Bogay Bogay marked this pull request as ready for review June 7, 2023 19:52
@Bogay
Copy link
Member Author

Bogay commented Jun 7, 2023

根據之前和 @as535364 的討論,可能會多加上允許部分測資公開(不論 CE 與否)的功能,討論完成前先改 Draft。

為了不要 block 目前繼續寫 submission 測試,討論移到 #207,之後另開 PR

cap = self.Permission.OTHER
else:
cap = self.Permission(0)

# students can view outputs of their CE submissions
CE = 2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之後應該要把這種 constant 集中管理

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #264

@Bogay Bogay merged commit ba8815e into develop Jun 7, 2023
@Bogay Bogay deleted the feat/allow-view-CE-stderr branch June 7, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants