Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/auth #214

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Test/auth #214

merged 4 commits into from
Jun 5, 2023

Conversation

AlaRduTP
Copy link
Member

@AlaRduTP AlaRduTP commented Jun 3, 2023

Reach 100% coverage of model/auth.py.

@AlaRduTP
Set test client app config: SERVER_NAME.
082b720
@AlaRduTP
Add several test cases for model/auth.py.
4e1fc00 
Tested routes under `/auth` include:

- /change-password
- /check/<item>
- /resend-email
- /batch-signup
- /me

As well as two wrapper functions:

- login_required
- identity_verify
@AlaRduTP
Format code with yapf and add some test cases for model/auth.py.
7ffef96 
Tested routes include:

- /active
- /password-recovery
@AlaRduTP AlaRduTP added the enhancement New feature or request label Jun 3, 2023
@AlaRduTP AlaRduTP added this to the 100% unit test coverage milestone Jun 3, 2023
@AlaRduTP AlaRduTP requested review from Bogay and uier June 3, 2023 12:00
@AlaRduTP AlaRduTP self-assigned this Jun 3, 2023
@AlaRduTP AlaRduTP requested a review from as535364 as a code owner June 3, 2023 12:00
Bogay
Bogay reviewed Jun 3, 2023
View reviewed changes
tests/test_auth.py Outdated Show resolved Hide resolved
tests/test_auth.py Show resolved Hide resolved
Bogay
Bogay approved these changes Jun 3, 2023
View reviewed changes
Copy link
Member

@Bogay Bogay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlaRduTP AlaRduTP merged commit b5abe73 into develop Jun 5, 2023
@uier uier mentioned this pull request May 23, 2023
Open
27 tasks
@Bogay Bogay deleted the test/auth branch June 23, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bogay Bogay Bogay approved these changes

@uier uier Awaiting requested review from uier

@as535364 as535364 Awaiting requested review from as535364 as535364 is a code owner

Assignees

@AlaRduTP AlaRduTP

Labels
enhancement New feature or request
Projects
None yet
Milestone
100% unit test coverage
Development

Successfully merging this pull request may close these issues.
2 participants
@AlaRduTP @Bogay