feat: update table width in pages/courses
#146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laporchen
changed the title
courses
laporchen
changed the title
coursespage/courses
laporchen
changed the title
page/coursespages/courses
Deploying with
|
| Latest commit: |
6115991
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://377fbb0c.nfe.pages.dev |
| Branch Preview URL: | https://feat-courses-page-mobile.nfe.pages.dev |
10 tasks
uier
reviewed
Aug 7, 2023
| <td> | ||
| <td | ||
| :class="{ | ||
| 'min-w-[10rem] max-w-[12rem] whitespace-pre-wrap': !isDesktop, |
There was a problem hiding this comment.
I'm curious whether isDesktop is a common usage in RWD? The last time I applied RWD, I was using like lgAndUp, mdAndDown. just discussion :D
There was a problem hiding this comment.
I think there are multiple methods to apply RWD. Like inline class with lg, md, for example.
Using isDesktop to separate two width ranges with dynamic binding is easier to maintain in my opinion.
If there's more than 2 device widths to consider. I think the one you mentioned would be a better solution.
I don't think we are making more design other than mobile right now.
uier
approved these changes
Aug 7, 2023
|
@laporchen remember to assign yourself as one of the PR Assignees, and after the changes approved you can Squash and merge the changes by yourself! thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing the table being centered in the
coursespage.