Fixes #14052: create a rudder server trigger_policy_generation command #199
Conversation
| done | ||
|
|
||
| # check if the API is available | ||
| if netstat -lnt | grep -q "8080" > /dev/null |
There was a problem hiding this comment.
maybe better to use the status API?
There was a problem hiding this comment.
ha, i was wondering what was the state of the art for that
ncharles
force-pushed
the
bug_14052/create_a_rudder_server_trigger_policy_generation_command
branch
from
666753b
to
63f1700
Compare
|
Commit modified |
| then | ||
| echo "Successfully triggered a new policy generation" | ||
| else | ||
| echo "Failed to trigger a policy " |
There was a problem hiding this comment.
we should return 1 in this case
There was a problem hiding this comment.
and display the message on stderr
ncharles
force-pushed
the
bug_14052/create_a_rudder_server_trigger_policy_generation_command
branch
from
63f1700
to
01147aa
Compare
|
Commit modified |
| . "${BASEDIR}/../lib/api_call.sh" | ||
|
|
||
| TOKEN="$(cat /var/rudder/run/api-token)" | ||
| DISPLAY_COMMAND=false |
There was a problem hiding this comment.
This is never used, it should always be the 5th arg of filtered_api_call, see api_call.sh
| done | ||
|
|
||
| # check if the API is available | ||
| api_result=$(filtered_api_call "${API_URL}/api/system/status" "${TOKEN}" "GET" -f) |
There was a problem hiding this comment.
The request need an api version, most likely "latest", and add the DISPLAY_COMMAND arg
|
|
||
| if [ ${api_code} -eq 0 ] | ||
| then | ||
| result=$(filtered_api_call "${API_URL}/api/system/update/policies" "${TOKEN}" "POST" -f) |
There was a problem hiding this comment.
The request need an api version, most likely "latest", and add the DISPLAY_COMMAND arg
ncharles
force-pushed
the
bug_14052/create_a_rudder_server_trigger_policy_generation_command
branch
from
01147aa
to
3a13261
Compare
|
Commit modified |
|
OK, merging this PR |
https://issues.rudder.io/issues/14052