Fixes #14182: Remove initial promises from rudder agent package #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Jan 22, 2019
rudder-webapp/SOURCES/Makefile
Outdated
| initial-ncf: ./rudder-sources ./initial-promises | ||
| rm -rf ./initial-ncf | ||
| cp -r ./rudder-sources/ncf/tree ./initial-ncf | ||
| # retreive the rudder specific ncf.conf |
amousset
reviewed
Jan 22, 2019
rudder-webapp/SOURCES/Makefile
Outdated
| cp -r initial-promises/ $(DESTDIR)/opt/rudder/share/ | ||
| cp -r initial-ncf/ $(DESTDIR)/opt/rudder/share/ | ||
|
|
||
| touch $@ |
|
Commit modified |
|
@peck needs rebase |
|
PR rebased |
peckpeck
force-pushed
the
arch_14182/remove_initial_promises_from_rudder_agent_package
branch
from
f495295
to
715f689
Compare
amousset
reviewed
Mar 22, 2019
| @@ -200,19 +200,7 @@ then | |||
| RESTORE_SERVER_ROLES_BACKUP=1 | |||
| fi | |||
|
|
|||
| # Copy initial promises if there aren't any already or, | |||
There was a problem hiding this comment.
Don't we need another fallback? (like remove policies if they are corrupted?)
|
you should remove the copy l322 and 323 (can't link it in conversation somehow) rudder-packages/rudder-agent/SOURCES/Makefile Line 322 in 715f689 |
peckpeck
force-pushed
the
arch_14182/remove_initial_promises_from_rudder_agent_package
branch
from
715f689
to
87d3380
Compare
|
Commit modified |
amousset
approved these changes
Apr 29, 2019
|
OK, merging this PR |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/14182