Fixes #4280: Correct the SLES apache include addition to apache2 sysconf... #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -207,6 +206,14 @@ then | |||
| cp -a %{rudderdir}/share/techniques /var/rudder/configuration-repository/ | |||
| fi | |||
|
|
|||
| # Add required includes in the SLES apache2 configuration | |||
| %if 0%{?sles_version} | |||
| if ! grep -q ". /etc/sysconfig/rudder-apache" /etc/sysconfig/apache2 | |||
There was a problem hiding this comment.
Please make your grep command more precise (and less error-prone) by using an anchored regexp. This could so easily match a commented line and cause endless headaches to solve...
Kegeruneku
pushed a commit
that referenced
this pull request
Jan 15, 2014
…sysconfig_includes_in_all_cases Fixes #4280: Correct the SLES apache include addition to apache2 sysconf...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ig
Ticket: http://www.rudder-project.org/redmine/issues/4280
To be merged in 2.4 upwards