Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15250: Add set -e in the qa-test of rudder-packages #1985

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Jul 19, 2019

@peckpeck
Copy link
Member

checks have failed

@Fdall Fdall force-pushed the bug_15250/add_set_e_in_the_qa_test_of_rudder_packages branch from 3d38bf9 to b7270a0 Compare July 22, 2019 10:24
@Fdall
Copy link
Contributor Author

Fdall commented Jul 22, 2019

Commit modified

@Fdall
Copy link
Contributor Author

Fdall commented Jul 22, 2019

PR rebased

@Fdall Fdall force-pushed the bug_15250/add_set_e_in_the_qa_test_of_rudder_packages branch from b7270a0 to 6b0b8a1 Compare July 22, 2019 10:26
@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Branch 'branches/rudder/5.0' set up to track remote branch 'branches/rudder/5.0' from 'NRM'.
Your branch is up to date with 'NRM/branches/rudder/5.0'.
Already up to date.
Already up to date.
[...]
 * [new branch]        bug_15250/add_set_e_in_the_qa_test_of_rudder_packages -> bug_15250/add_set_e_in_the_qa_test_of_rudder_packages_pr
From github.com:Normation/rudder-packages
   29dd60b1..b98f06d4  branches/rudder/5.0 -> NRM/branches/rudder/5.0
   aa8cf86b..389a060e  master              -> NRM/master
Switched to branch 'branches/rudder/5.0'
Switched to a new branch '5.0_test'
+ find ./rudder-server-relay/SOURCES/relay-api/relay_api -name '*.py'
+ xargs pylint -E --disable=C,R,no-member,no-name-in-module --persistent=n
No config file found, using default configuration

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/rudder-packages/pull/1985 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/12603/console)

@Fdall
Copy link
Contributor Author

Fdall commented Jul 23, 2019

OK, merging this PR

@Fdall Fdall merged commit 6b0b8a1 into Normation:branches/rudder/5.0 Jul 23, 2019
@Fdall
Copy link
Contributor Author

Fdall commented Jul 23, 2019

OK, merging this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants