Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4466: add detect_os.sh script #220

Conversation

VinceMacBuche
Copy link
Member

http://www.rudder-project.org/redmine/issues/4466

Not finished yet, an error with missing perl-5.12.4.tar.gz file occurs here

@jooooooon
Copy link
Member

This is an over-simplified view of this change.

The detect-os.sh file comes from an internal repository that we use to build packages (it is internal because it contains SSH keys and hostnames to our internal IT infrastructure). Clearly, the detect-os.sh file should be in the public rudder-packages repository, not in there.

But we can't just go around duplicating code, and making this work for one package! That file is used in all package builds. If we add it here, we must remove it from the internal packaging repo (DRY is not just a buzz word, it's what we do, without exception).

Please rework this, including the internal packaging repo in your considerations.

@Kegeruneku
Copy link

Creating another PR using this one. See ticket.

@Kegeruneku Kegeruneku closed this Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants