Fixes #17592: rudder-webapp could suggest rudder-reports #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdall
approved these changes
Jun 2, 2020
|
OK, merging this PR |
ncharles
reviewed
Jun 2, 2020
| @@ -12,6 +12,7 @@ Pre-Depends: ${rudder:deps} | |||
| Depends: ${shlibs:Depends}, ${misc:Depends}, systemd, iproute2, rsyslog, python3, apache2, apache2-utils, git-core, rsync, lsb-release, openssl, ldap-utils, postgresql-client (>=9.2), openjdk-11-jre-headless | openjdk-8-jre-headless | oracle-java8-installer | java11-runtime-headless, curl, acl | |||
| Breaks: ncf, ncf-api-virtualenv, rudder-techniques, rudder-inventory-endpoint, rudder-jetty, rudder-inventory-ldap, rudder-ldap, rudder-agent (<< 6.0.0) | |||
| Replaces: ncf, ncf-api-virtualenv, rudder-techniques, rudder-inventory-endpoint, rudder-jetty, rudder-inventory-ldap, rudder-ldap | |||
| Suggests: rudder-reports | |||
There was a problem hiding this comment.
i think it should Recommends
https://www.debian.org/doc/debian-policy/ch-relationships.html
Recommends
This declares a strong, but not absolute, dependency.
The Recommends field should list packages that would be found together with this one in all but unusual installations.
Suggests
This is used to declare that one package may be more useful with one or more others. Using this field tells the packaging system and the user that the listed packages are related to this one and can perhaps enhance its usefulness, but that installing this one without them is perfectly reasonable.
peckpeck
deleted the
bug_17592/rudder_webapp_could_suggest_rudder_reports
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17592