Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4744: Update Fusion Inventory to 2.3.6 for AIX builds #300

Merged
merged 1 commit into from Apr 16, 2014
Merged

Fixes #4744: Update Fusion Inventory to 2.3.6 for AIX builds #300

merged 1 commit into from Apr 16, 2014

Conversation

Kegeruneku
Copy link

Ticket: http://www.rudder-project.org/redmine/issues/4744

To be merged in 2.10_aix

@jooooooon
Copy link
Member

@Kegeruneku, I think this is slightly missing the goal here. What we want to achieve, in the end, is a single branch that has Fusion 2.3.6 for AIX, and Fusion 2.2.* for other OSes.

We are using a 2.10_aix branch in between, so that we don't break anything on the main 2.10 branch, but this branch will be merged into the main 2.10 branch in the near future.

Therefore, we must not remove all patches relating to FusionInventory 2.2., but instead keep them living alongside 2.3.6 patches, and make sure to download *both versions.

Do you understand, and can you amend please?

@Kegeruneku
Copy link
Author

Updated. Introduced a "patches" folder to ease patch management for rudder-agent

@Kegeruneku
Copy link
Author

Do not merge yet please.

@Kegeruneku
Copy link
Author

OK, ready to merge :)

cd $PWD/../../fusioninventory-agent-2.3.6
else
cd $PWD/../../fusioninventory-agent-2.2.2
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please move the OS-specific logic out of this file, and keep it all in the .spec file? This would respect POLA a lot more... And avoid nasty debugging in the future, I think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea from chatting together: make the directory to build an argument to the perl-prepare.sh script.

@Kegeruneku Kegeruneku changed the title Fixes #4744: Update Fusion Inventory to 2.3.6 Fixes #4744: Update Fusion Inventory to 2.3.6 for AIX builds Apr 16, 2014
@@ -78,6 +78,15 @@ localdepends: ./initial-promises ./detect_os.sh ./files ./fusioninventory-agent
# Fix a lsusb invocation that crashes some SLES machines
$(FIND) ./fusioninventory-agent -iname "USB.pm" -exec rm "{}" \;

./fusioninventory-agent-2.3.6: /usr/bin/wget
$(WGET) -O $(TMP_DIR)/fusion-2.3.6.tgz http://www.normation.com/tarball/FusionInventory-Agent-2.3.6.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify the original URL here

jooooooon added a commit that referenced this pull request Apr 16, 2014
…on_to_2_3_6

Fixes #4744: Update Fusion Inventory to 2.3.6 for AIX builds
@jooooooon jooooooon merged commit 3d22ce4 into Normation:branches/rudder/2.10_aix Apr 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants