Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #6567: Add a script to manage node keys on server #653

Merged
merged 1 commit into from
May 7, 2015
Merged

Fixes #6567: Add a script to manage node keys on server #653

merged 1 commit into from
May 7, 2015

Conversation

peckpeck
Copy link
Member

@peckpeck peckpeck commented May 6, 2015

@peckpeck peckpeck force-pushed the arch_6567/add_a_script_to_manage_node_keys_on_server branch from ac65671 to 5f72b97 Compare May 6, 2015 14:00
@peckpeck
Copy link
Member Author

peckpeck commented May 6, 2015

PR updated

@amousset
Copy link
Member

amousset commented May 7, 2015

Should this be added to rudder cli ? (like rudder server debug).

amousset
amousset reviewed May 7, 2015
View reviewed changes
rudder-webapp/SOURCES/rudder-keys
then

ldapmodify ${LDAP_PARAMETERS} <<EOF
dn: nodeId=nodeId=${UUID},${ACCEPTED_NODES_BASE}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two "nodeId=" in the dn.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I thought I had corrected it

@peckpeck
Copy link
Member Author

peckpeck commented May 7, 2015

I don't think this should be added to rudder cli.
This is a temporary script for a feature that should be added to the interface and to the API. It will then be time to remove the script.

@VinceMacBuche
Copy link
Member

After discussing with @fanf and @peckpeck, we agreed on the fact that those functions should not be in rudder-cli, and that they would be integrated via api functions (and rudder-api-cli)

However we will upgrade the error messages in ldap-inventory to talk about that script

@VinceMacBuche
Copy link
Member

Merging!

@VinceMacBuche
Copy link
Member

Not merging ;) the dn 'nodeid=nodeid=' is not fixed @peckpeck ;)

@peckpeck
Copy link
Member Author

peckpeck commented May 7, 2015

PR updated

@peckpeck peckpeck force-pushed the arch_6567/add_a_script_to_manage_node_keys_on_server branch from 5f72b97 to 69dbe52 Compare May 7, 2015 10:53
@VinceMacBuche
Copy link
Member

Thanks @peckpeck ! merging

VinceMacBuche added a commit that referenced this pull request May 7, 2015
@VinceMacBuche
Merge pull request #653 from peckpeck/arch_6567/add_a_script_to_manag…
19cd8b4 
…e_node_keys_on_server

Fixes #6567: Add a script to manage node keys on server
@VinceMacBuche VinceMacBuche merged commit 19cd8b4 into Normation:branches/rudder/3.1 May 7, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peckpeck @amousset @VinceMacBuche