Fixes #7117: Use the webhelp doc as embedded doc in the webapp #739
Conversation
|
Should not be merged before Normation/rudder-doc#134. |
| mkdir -p ./rudder-doc/pdf | ||
| # Move the generated PDF from html directory to pdf | ||
| mv ./rudder-doc/html/rudder-doc.pdf ./rudder-doc/pdf/ | ||
| $(WGET) -P ./rudder-doc/html -r -np -nH --cut-dirs=1 http://www.rudder-project.org/doc-${RUDDER_MAJOR_VERSION}/index.html |
There was a problem hiding this comment.
Please don't include the index.html at the end of the URL. I'd rather use a standard URL and let the webserver serve whatever it thinks (aka what we configure) is best.
amousset
force-pushed
the
ust_7117/use_the_webhelp_doc_as_embedded_doc_in_the_webapp
branch
from
cd7f27d
to
2bf5fc9
Compare
|
PR updated. |
| mv ./rudder-doc/html/rudder-doc.pdf ./rudder-doc/pdf/ | ||
| $(WGET) -P ./rudder-doc/html -r -np -nH --cut-dirs=1 http://www.rudder-project.org/doc-${RUDDER_MAJOR_VERSION}/ | ||
| # Download the pdf version of the manual | ||
| $(WGET) -P ./rudder-doc/pdf 1 http://www.rudder-project.org/rudder-doc-${RUDDER_MAJOR_VERSION}/rudder-doc.pdf |
There was a problem hiding this comment.
The "1" here looks like a typo.
amousset
force-pushed
the
ust_7117/use_the_webhelp_doc_as_embedded_doc_in_the_webapp
branch
from
2bf5fc9
to
1309ff2
Compare
|
PR updated. |
|
This looks good now, but I don't think we should make the change on the 2.10 branch. This is not a bug fix, so does not fit our policy for changes on maintenance releases. Also, it would be a very surprising change in user experience for any users used to consulting that documentation, that suddenly after a minor version upgrade, changes completely. Please retarget to master unless you see a reason I'm missing here. |
|
Sure, retargeting. |
https://www.rudder-project.org/redmine/issues/7117