Fixes #7443: Call rudderify from rudder upgrade #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Call rudderify on all local ncf techniques to make sure the promises will be properly generated | ||
| rudderify_techniques() { | ||
| STEP="Call rudderify on all local ncf techniques (#7443)" | ||
| /usr/share/ncf/tools/ncf_rudder.py rudderify_technique /var/rudder/configuration-repository/techniques/ncf_techniques |
There was a problem hiding this comment.
Fonction called should be rudderify_techniques !
Rudderify_technique only rudderify the technique passes as parameter!!
|
PR updated |
peckpeck
force-pushed
the
ust_7443/call_rudderify_from_rudder_upgrade
branch
from
69f7293
to
b6f5afc
Compare
|
It should also reload techniques ! Two ways: Call reload techniques API |
|
Indeed, if the rudderify modify does something, it should call trigger_technique_library_reload |
|
PR updated |
peckpeck
force-pushed
the
ust_7443/call_rudderify_from_rudder_upgrade
branch
from
b6f5afc
to
e06d830
Compare
jooooooon
added a commit
that referenced
this pull request
Nov 23, 2015
…dder_upgrade Fixes #7443: Call rudderify from rudder upgrade
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7443